Allow $sync to be called manually #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zknill
force-pushed
the
feature/COL-40-replace-update-function-merge-function
branch
2 times, most recently
from
99e6914 to
2f9adbd
Compare
Base automatically changed from
feature/COL-40-replace-update-function-merge-function
to
main
October 16, 2023 11:15
Replace the per-channel-per-event update function mapping with a single merge function. This makes the UpdatesRegistry redundant, as we don't need a class to hold the old mapping: "channel -> eventName -> function" Update the tests, and rename some update terminology to merge. Also: - accept the channel name as a constructor argument to the Model.
zknill
force-pushed
the
feature/COL-42-allow-sync-manually-called
branch
from
2c87e88 to
5bc8b45
Compare
Expose the sync function that can be called manually to resync the model. On resync the model will go into the preparing state, and then the ready state when the sync is complete. Add tests.
zknill
force-pushed
the
feature/COL-42-allow-sync-manually-called
branch
from
5bc8b45 to
51c7870
Compare
mschristensen
requested changes
Oct 16, 2023
zknill
force-pushed
the
feature/COL-42-allow-sync-manually-called
branch
from
402b6cb to
c9a56b1
Compare
mschristensen
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the sync function that can be called manually to resync the model. On resync the model will go into the preparing state, and then the ready state when the sync is complete.
Add tests.